Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: Prevent Auto-Mode Tipovers caused by missing takeoff command #4102

Closed
wants to merge 1 commit into from

Conversation

nitirohilla
Copy link
Contributor

This PR resolves the issue #4039.

As per this PR, the system will deny switching to auto mode if land is completed and motors are armed but the next command in the mission is lateral flying.

@R-Lefebvre
Copy link
Contributor

I'm not familiar enough with this part of the code to review this, but thanks!

@OXINARF OXINARF added the Copter label May 14, 2016
@rmackay9 rmackay9 self-assigned this May 16, 2016
@rmackay9
Copy link
Contributor

I saw something very similar to this over the weekend when a new user set a target position in Guided mode. It's not exactly the same issue so this set of patches won't resolve that issue but I reminded me of this issue. Anyway, thanks and I'll review hopefully in the next couple of days.

@rmackay9
Copy link
Contributor

Merged, thanks!
Nice PR. I made a few small changes:

  • split the first commit into two (we like a single commit to only affect a single vehicle or a single library)
  • moved the check higher in auto_init so that there can be no side-effects if the switch to auto fails. It's hard to think of how it could actually happen but with the check where it was, the "wp_nav.wp_and_spline_init" line would have been run even though the switch to auto failed.

@rmackay9 rmackay9 closed this May 19, 2016
@nitirohilla
Copy link
Contributor Author

Thanks @rmackay9 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants